Feature/13 scarp reasons codes#53
Merged
Merged
Conversation
…/TR keys Index/Create/Edit and fields.js now translate all labels via the __() helper instead of rendering hard-coded English. fields.js exports factory functions (scrapReasonFields/scrapCategoryOptions) so labels are resolved at render time, after the locale chunk loads at bootstrap. Adds the 4 keys these screens reference that were missing from the lang files (+ New Reason, No scrap reasons yet., Used, Delete scrap reason ":name"?) to pl.json (Polish), en.json (identity) and tr.json (Turkish). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Brings develop (Work Order History, process photos, lot patterns, realtime refactor, etc.) into the scrap-reasons i18n branch. Conflict resolutions: - lang/pl.json, lang/en.json: union of both key sets (develop wins on shared keys; "Report" -> develop's "Raport"). Our 4 new scrap keys kept. - adminNav.js: dropped duplicate Reports from the Admin group (develop moved it to a dedicated Reports group) and moved our "Scrap Reports" entry into that Reports group alongside "Work Order History". - CHANGELOG.md: kept both Added blocks + develop's Changed note. - Operator/WorkOrderController.php: keep develop's processPhotos block; render both scrapReasons and processPhotos. - operator/WorkOrderDetail.jsx: destructure both scrapReasons and processPhotos. Verified: pl/en/tr JSON valid, PHP lints clean, vite build succeeds. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…/13-scarp-reasons-codes Brings develop's inspection-plan version/publish lifecycle (#62). No scrap files touched by the incoming commits. Conflict resolutions: - lang/pl.json, lang/en.json: union of both key sets (no value conflicts); our scrap keys kept, develop's inspection keys added. - routes/web.php: kept our scrap-reports route AND develop's new inspection-plans publish route. Verified: pl/en/tr JSON valid, php -l routes/web.php clean, vite build succeeds. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…on UI) into feature/13-scarp-reasons-codes
Resolves the PR's pl.json/en.json conflicts. No scrap files touched by the
incoming commits; adminNav.js auto-merged (our Reports group + Scrap Reasons kept).
Conflict resolutions:
- lang/pl.json, lang/en.json: union of both key sets. NOTE: develop's blobs were
malformed JSON (missing comma after "Version history" before "CLOSED"); repaired
during merge so the files parse. Develop wins on shared keys ("Used" -> "Użyte").
Our scrap keys preserved. 3145 keys each.
Verified: pl/en/tr JSON valid, vite build succeeds.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
luizinhoh2o1
pushed a commit
to luizinhoh2o1/OpenMes
that referenced
this pull request
Jun 15, 2026
…-codes Feature/13 scarp reasons codes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds scrap reason codes: predefined, categorized (5M - material / machine / method / man / environment) defect reasons that operators
select when reporting scrap against a work order. Gives a per-work-order quality metric and a Pareto view of which reasons cause the most
scrap, so the team can prioritise the vital-few defect causes. Built on the current React/Inertia + Electric stack (admin CRUD + reports as
React pages, operator reporting on the work order detail).
Type of change
Related issue
Closes #13
Testing
Verified end to end against the running app (admin CRUD + reports, operator scrap reporting), plus an automated scrap suite. Covers reason
CRUD, operator entry creation, report data, per-work-order quality, and per-tenant isolation.
php artisan testpasses - scrap suite green (30/30); the ~12 unrelated pre-existing failures (CsvImport, modules, PIN login,onboarding) predate this branch, confirmed via
git stash. Run withphp -d memory_limit=2G vendor/bin/phpunit(suite exceeds 128M in oneprocess).
Checklist
.envsecrets committed$fillableupdated if new model columns addedcomposer auditclean - reports pre-existing transitive advisories (e.g.symfony/routingCVE-2026-45065); not introduced by this PR